Re: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support

From: Fabio Estevam
Date: Wed Feb 27 2019 - 20:32:41 EST


Hi Anson,

On Wed, Feb 27, 2019 at 10:23 PM Anson Huang <anson.huang@xxxxxxx> wrote:
>
> i.MX7ULP has a MMDC module to control DDR, it reuses
> i.MX6Q's MMDC module, add support for it.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> ---
> Changes since V1:
> - use "memory-controller" as MMDC node name to make it more generic.
> ---
> arch/arm/boot/dts/imx7ulp.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index fca6e50..78f6117 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -286,6 +286,12 @@
> status = "disabled";
> };
>
> + mmdc: memory-controller@40ab0000 {

It seems that the 'mmdc' label is not neeed.

You could make it simpler as:

memory-controller@40ab0000 {