RE: [PATCH] sched/cputime: Remove unnecessary assignment statement

From: Sachin Nikam
Date: Thu Feb 28 2019 - 07:14:26 EST


Ketan,
What is the Coverity Impact Level for this defect?
If it is Low then we can whitelist this defect and change.

Peter,
This isn't a security fix.
However, I see this is kind of code cleanup.

-----Original Message-----
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Sent: Thursday, February 28, 2019 3:18 PM
To: Ketan Patil <ketanp@xxxxxxxxxx>
Cc: mingo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Sachin Nikam <Snikam@xxxxxxxxxx>; Bharat Nihalani <bnihalani@xxxxxxxxxx>; Bo Yan <byan@xxxxxxxxxx>; Sai Gurrappadi <sgurrappadi@xxxxxxxxxx>; Thierry Reding <treding@xxxxxxxxxx>; Timo Alho <talho@xxxxxxxxxx>
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Thu, Feb 28, 2019 at 03:12:13PM +0530, Ketan Patil wrote:
> The coverity tool has detected this issue as an unused value, since
> the code assigns the value to utime variable and then after the jump,
> the value of utime again gets updated, hence the previous value is not
> at all useful and this patch removes that first assignment.

Not a security issue then; just tell coverity to shut up.