Re: [PATCH v2] dt-bindings: hwmon: Add missing documentation for lm75

[Rob Herring]

On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote:
> Add missing dt-binding documentation for lm75 hwmon sensor.
> 
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> ---
> Changes for v2:
> -  Add all compatible nodes available in lm75.
> 
>  .../devicetree/bindings/hwmon/lm75.txt        | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> new file mode 100644
> index 000000000000..12d8cf7cf592
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -0,0 +1,37 @@
> +*LM75 hwmon sensor.
> +
> +Required properties:
> +- compatible: manufacturer and chip name, one of
> +		"adi,adt75",
> +		"dallas,ds1775",
> +		"dallas,ds75",
> +		"dallas,ds7505",
> +		"gmt,g751",
> +		"national,lm75",
> +		"national,lm75a",
> +		"national,lm75b",
> +		"maxim,max6625",
> +		"maxim,max6626",
> +		"maxim,max31725",
> +		"maxim,max31726",
> +		"maxim,mcp980x",
> +		"st,stds75",
> +		"st,stlm75",
> +		"microchip,tcn75",
> +		"ti,tmp100",
> +		"ti,tmp101",
> +		"ti,tmp105",
> +		"ti,tmp112",
> +		"ti,tmp175",
> +		"ti,tmp275",
> +		"ti,tmp75",
> +		"ti,tmp75c",

Some of these are in trivial-devices.yaml already. So you either need to 
remove them from there. Or you can move all these to trivial-devices and 
benefit from having a schema. I prefer the latter, but either way is 
fine. You can remove them from trivial-devices.yaml in a separate patch, 
so:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

Rob

P.S. Third option is convert this doc to DT schema. Don't tell anyone, 
but you'll be a the top of my review queue.