Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly

From: Andrew Morton
Date: Thu Feb 28 2019 - 13:22:33 EST


On Thu, 28 Feb 2019 05:53:37 -0700 William Kucharski <william.kucharski@xxxxxxxxxx> wrote:

> > On Feb 28, 2019, at 1:33 AM, Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> wrote:
>
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index a9852ed7b97f..2d081a32c6a8 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -1614,8 +1614,8 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> >
> > }
> >
> > -/*
> > - * zone_lru_lock is heavily contended. Some of the functions that
> > +/**
>
> Nit: Remove the extra asterisk here; the line should then revert to being unchanged from
> the original.

I don't think so. This kernedoc comment was missing its leading /**.
The patch fixes that.