Re: [PATCH] sctp: chunk.c: correct format string for size_t in printk
From: David Miller
Date: Thu Feb 28 2019 - 13:34:15 EST
From: Matthias Maennich <maennich@xxxxxxxxxx>
Date: Thu, 28 Feb 2019 11:36:52 +0000
> According to Documentation/core-api/printk-formats.rst, size_t should be
> printed with %zu, rather than %Zu.
>
> In addition, using %Zu triggers a warning on clang (-Wformat-extra-args):
>
> net/sctp/chunk.c:196:25: warning: data argument not used by format string [-Wformat-extra-args]
> __func__, asoc, max_data);
> ~~~~~~~~~~~~~~~~^~~~~~~~~
> ./include/linux/printk.h:440:49: note: expanded from macro 'pr_warn_ratelimited'
> printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
> ./include/linux/printk.h:424:17: note: expanded from macro 'printk_ratelimited'
> printk(fmt, ##__VA_ARGS__); \
> ~~~ ^
>
> Fixes: 5b5e0928f742 ("lib/vsprintf.c: remove %Z support")
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Matthias Maennich <maennich@xxxxxxxxxx>
Applied, thanks.