Re: + include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch added to -mm tree

From: Alexey Dobriyan
Date: Thu Feb 28 2019 - 16:11:33 EST


On Thu, Feb 28, 2019 at 09:41:09AM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> --- a/include/linux/types.h~include-linux-typesh-use-unsigned-int-instead-of-unsigned
> +++ a/include/linux/types.h
> @@ -155,9 +155,9 @@ typedef u64 dma_addr_t;
> typedef u32 dma_addr_t;
> #endif
>
> -typedef unsigned __bitwise gfp_t;
> -typedef unsigned __bitwise slab_flags_t;
> -typedef unsigned __bitwise fmode_t;
> +typedef unsigned int __bitwise gfp_t;
> +typedef unsigned int __bitwise slab_flags_t;
> +typedef unsigned int __bitwise fmode_t;

I don't know if this is desireable. Switching to "unsigned" is better:
1 less token and less 80 column pressure.