On Thu, Mar 07, 2019 at 05:39:02PM +0100, Ludovic Barre wrote:
- if (data->flags & MMC_DATA_READ)
- datactrl |= MCI_DPSM_DIRECTION;
Given that this is currently an invariant between all, it doesn't make
sense to have a separate public function and combine it into the
get_datactrl_cfg() implementations. You may as well leave it in place
here, after you call get_datactrl_cfg().
+ datactrl = host->ops->get_datactrl_cfg(host);
Otherwise, I don't see a problem with this, although it would be nice to
avoid the overhead of so many public functions, which could be done by
adding them as inline functions in mmci.h