Re: [PATCH 12/20] objtool: Set insn->func for alternatives

[Peter Zijlstra]

On Fri, Mar 08, 2019 at 01:16:29PM -0600, Josh Poimboeuf wrote:
> On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote:
> > Make sure we set the function association for alternative instruction
> > sequences; they are after all still part of the function.
> 
> Can you also say _why_?  I presume it's so the warning messages will be
> saner.

Right; because I'll introduce function attributes later on, so it
becomes important to know what function an instruction belongs to.

I'll update the Changelog.

> > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > ---
> >  tools/objtool/check.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/tools/objtool/check.c
> > +++ b/tools/objtool/check.c
> > @@ -695,6 +695,7 @@ static int handle_group_alt(struct objto
> >  		last_new_insn = insn;
> >  
> >  		insn->ignore = orig_insn->ignore_alts;
> > +		insn->func = orig_insn->func;
> >  
> >  		if (insn->type != INSN_JUMP_CONDITIONAL &&
> >  		    insn->type != INSN_JUMP_UNCONDITIONAL)
> > 
> > 
> 
> -- 
> Josh