Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

From: Dan Murphy
Date: Fri Mar 08 2019 - 16:08:40 EST


Pavel

On 3/8/19 3:06 PM, Pavel Machek wrote:
>
>>>> + led@1 {
>>>> + reg = <1>;
>>>> + led-sources = <1>;
>>>> + ti,led-mode = <LM3532_BL_MODE_MANUAL>;
>>>> + label = "keypad";
>>>
>>> I guess best variant would be inputX::backlight here, but that might
>>> be tricky to implement.
>>>
>>
>> Yeah because we don't know what input the keyboard would be on.
>> Unless there are APIs to retrieve that info. I have not looked at the input
>> framework in a while.
>
> Lets just make it "platform::kbd_backlight". *:kbd_backlight is
> already used by quite a few drivers.
>

Sounds fine to me. I will update in v3 as I posted v2 with a lot of deltas

Dan

> Pavel
>


--
------------------
Dan Murphy