Re: [PATCH] rcu/tree_plugin: Fix nohz status in stall warning

From: Paul E. McKenney
Date: Fri Mar 08 2019 - 16:18:49 EST


On Fri, Mar 08, 2019 at 11:51:49PM +0530, Neeraj Upadhyay wrote:
> Fix stall warning, to show correct nohz marker.
>
> Signed-off-by: Neeraj Upadhyay <neeraju@xxxxxxxxxxxxxx>

Good eyes, thank you!

I applied and pushed all three with modified commit logs. Please check
to make sure that I didn't mess anything up. If testing and reviews
are OK, I expect to submit them for the v5.2 merge window.

I had to hand-apply this one, so in future patches could you please
generate them against -rcu? It may be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

Thanx, Paul

> ---
> kernel/rcu/tree_plugin.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 97dba50..93da32c 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1659,7 +1659,7 @@ static void print_cpu_stall_fast_no_hz(char *cp, int cpu)
> rdp->last_accelerate & 0xffff, jiffies & 0xffff,
> ".l"[rdp->all_lazy],
> ".L"[!rcu_segcblist_n_nonlazy_cbs(&rdp->cblist)],
> - ".D"[!rdp->tick_nohz_enabled_snap]);
> + ".D"[!!rdp->tick_nohz_enabled_snap]);
> }
>
> #else /* #ifdef CONFIG_RCU_FAST_NO_HZ */
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member of the Code Aurora Forum, hosted by The Linux Foundation
>