Re: [PATCH 3/4] Add header file,Kconfig and Makefile

[Randy Dunlap]

On 3/8/19 4:35 AM, Morris Ku wrote:
> This patch add header file, Kconfig and Makefile. 
> 
> Signed-off-by: Morris Ku <saumah@xxxxxxxxx>
> ---

> diff --git a/char/snx/Kconfig b/char/snx/Kconfig
> new file mode 100644
> index 00000000..86f38352
> --- /dev/null
> +++ b/char/snx/Kconfig
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Character device configuration
> +#
> +
> +config SNX
> +	tristate "SUNIX Multi-IO Board Drvier"

	                               Driver

> +	Driver for SUNIX Multi-I/O Board device driver Based on
> +	drivers/char/serial.c, parport_pc.c, ppdev.c and lp.c by Linus
> +	Torvalds, Theodore Ts'o.

kconfig does not like those 3 lines above.  That indicates some lack of
testing.

They could be put under "help", but they really should just be deleted or
moved to some source file if you think that they are needed.

> +	help
> +	   Say Y here if you have a SUNIX Multi-IO card.

Indent with tab + 2 spaces, not 3 spaces.

> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called snx.


-- 
~Randy