Re: [PATCH 1/2] amba: Take device out of reset before reading pid and cid values

[Linus Walleij]

On Sat, Mar 9, 2019 at 2:59 AM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:

> For the AMBA Primecell devices having the reset lines wired, it is
> necessary to take them out of reset before reading the pid and cid values.
> Earlier we were dependent on the bootloader to do this but a more cleaner
> approach would be to do it in the kernel itself. Hence, this commit
> deasserts the reset line just before reading the pid and cid values.
>
> Suggested-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

This looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I think you can put it in Russell's patch tracker in some week.

Yours,
Linus Walleij