Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64

[Tomohiro Mayama]

On 2019/03/09 11:52, Katsuhiro Suzuki wrote:
> Hello Mayama-san,
> 
> On 2019/03/08 1:18, Tomohiro Mayama wrote:
>> This patch makes USB ports functioning again.
>>
>> Signed-off-by: Tomohiro Mayama <parly-gh@xxxxxxxxxxxxxxx>
>> ---
>> Â arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
>> Â 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> index 21107d0f4378..7f365e448867 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> @@ -45,8 +45,7 @@
>> Â ÂÂÂÂÂ vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
>> ÂÂÂÂÂÂÂÂÂ compatible = "regulator-fixed";
>> -ÂÂÂÂÂÂÂ enable-active-high;
>> -ÂÂÂÂÂÂÂ gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
>> +ÂÂÂÂÂÂÂ gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
>> ÂÂÂÂÂÂÂÂÂ pinctrl-names = "default";
>> ÂÂÂÂÂÂÂÂÂ pinctrl-0 = <&usb20_host_drv>;
>> ÂÂÂÂÂÂÂÂÂ regulator-name = "vcc_host1_5v";
>>
> 
> After this patch applied, USB and S/PDIF both work well.
> 
> Tested-by: Katsuhiro Suzuki <katsuhiro@xxxxxxxxxxxxx>
> 
> 
> $ lsusb
> Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 001 Device 002: ID 046d:c526 Logitech, Inc. Nano Receiver
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> 
> 
> Best Regards,
> Katsuhiro Suzuki
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

Thank you for testing my patch, Suzuki-san!

Regards,
Tomohiro Mayama