Re: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference

[David Miller]

From: Kangjie Lu <kjlu@xxxxxxx>
Date: Fri,  8 Mar 2019 23:46:04 -0600

> In case ioremap fails, the fix reports an error and returns.
> 
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>

First, you shouldn't print the information log message if this fails.

Second you are leaking hc->hw.fifos, you have to clean up any resources
allocated up until this point if you fail.