Re: [PATCH] vmlinux.lds.h: drop unused __vermagic

[Mathias Krause]

Hi Jessica,

On Mon, 21 Jan 2019 at 12:39, Mathias Krause <minipli@xxxxxxxxxxxxxx> wrote:
>
> On Wed, 2 Jan 2019 at 21:29, Jessica Yu <jeyu@xxxxxxxxxx> wrote:
> >
> > +++ Mathias Krause [30/12/18 13:40 +0100]:
> > >The reference to '__vermagic' is a relict from v2.5 times. And even
> > >there it had a very short life time, from v2.5.59 (commit 1d411b80ee18
> > >("Module Sanity Check") in the historic tree) to v2.5.69 (commit
> > >67ac5b866bda ("[PATCH] complete modinfo section")).
> > >
> > >Neither current kernels nor modules contain a '__vermagic' section any
> > >more, so get rid of it.
> > >
> > >Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> > >Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > >Cc: Jessica Yu <jeyu@xxxxxxxxxx>
> >
> > Thanks for the cleanup.
> >
> > Reviewed-by: Jessica Yu <jeyu@xxxxxxxxxx>
> >
>
> Arnd, will you carry this patch through your asm-generic tree or did
> the MAINTAINERS file mislead me here?
>

looks like Arnd keeps ignoring my Emails. :/ Can you carry this patch
through your module tree? Or do you think I should ask Andrew Morton
instead?

Thanks,
Mathias

> > >---
> > > include/asm-generic/vmlinux.lds.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > >diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> > >index 3d7a6a9c2370..530ce1e7a1ec 100644
> > >--- a/include/asm-generic/vmlinux.lds.h
> > >+++ b/include/asm-generic/vmlinux.lds.h
> > >@@ -332,7 +332,6 @@
> > >               __start_rodata = .;                                     \
> > >               *(.rodata) *(.rodata.*)                                 \
> > >               RO_AFTER_INIT_DATA      /* Read only after init */      \
> > >-              KEEP(*(__vermagic))     /* Kernel version magic */      \
> > >               . = ALIGN(8);                                           \
> > >               __start___tracepoints_ptrs = .;                         \
> > >               KEEP(*(__tracepoints_ptrs)) /* Tracepoints: pointer array */ \
> > >--
> > >2.19.2
> > >