Re: [PATCH] iwlwifi: mvm: Change an 'else if' into an 'else' in iwl_mvm_send_add_bcast_sta

[Luca Coelho]

On Thu, 2019-03-07 at 16:08 -0800, Nick Desaulniers wrote:
> On Thu, Mar 7, 2019 at 4:03 PM Nathan Chancellor
> <natechancellor@xxxxxxxxx> wrote:
> > When building with -Wsometimes-uninitialized, Clang warns:
> > 
> > drivers/net/wireless/intel/iwlwifi/mvm/sta.c:2114:12: warning:
> > variable
> > 'queue' is used uninitialized whenever 'if' condition is false
> > [-Wsometimes-uninitialized]
> > 
> > Clang can't evaluate at this point that WARN(1, ...) always returns
> > true
> > because __ret_warn_on is defined as !!(condition), which isn't
> > immediately evaluated as 1. Change this branch to else so that it's
> > clear to Clang that we intend to bail out here.
> > 
> > Link: https://github.com/ClangBuiltLinux/linux/issues/399
> > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> 
> Thanks for the simple fix.
> Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

Thanks for the patch and for the review!

I have applied it in our internal tree and it will reach the mainline
following our normal upstreaming process.

--
Cheers,
Luca.