Re: [GIT pull] scheduler updates for 5.1

[Thomas Gleixner]

On Sun, 10 Mar 2019, Linus Torvalds wrote:
> On Sun, Mar 10, 2019 at 4:33 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> >
> > A small set of fixes for the scheduler:
> 
> What? No.
> 
> This is completely broken, and even warns loudly about it.
> 
>   kernel/sched/cpufreq_schedutil.c: In function âsugov_iowait_boostâ:
>   ./include/linux/kernel.h:827:29: warning: comparison of distinct
> pointer types lacks a cast
>   kernel/sched/cpufreq_schedutil.c:346:26: note: in expansion of macro âminâ
>      sg_cpu->iowait_boost = min(sg_cpu->iowait_boost << 1,
> SCHED_CAPACITY_SCALE);
>                             ^~~
> 
> because 'SCHED_CAPACITY_SCALE' is of type 'long' and 'iowait_boost' is
> 'unsigned int'.
> 
> Why are you sending me code that hasn't even been compiled, and call it a "fix"?

Sorry. Should have been more careful...

Thanks,

	tglx