RE: [PATCH v2] makedumpfile: exclude pages that are logically offline

From: Kazuhito Hagio
Date: Mon Mar 11 2019 - 12:42:04 EST


-----Original Message-----
> On 27.11.18 17:32, Kazuhito Hagio wrote:
> >> Linux marks pages that are logically offline via a page flag (map count).
> >> Such pages e.g. include pages infated as part of a balloon driver or
> >> pages that were not actually onlined when onlining the whole section.
> >>
> >> While the hypervisor usually allows to read such inflated memory, we
> >> basically read and dump data that is completely irrelevant. Also, this
> >> might result in quite some overhead in the hypervisor. In addition,
> >> we saw some problems under Hyper-V, whereby we can crash the kernel by
> >> dumping, when reading memory of a partially onlined memory segment
> >> (for memory added by the Hyper-V balloon driver).
> >>
> >> Therefore, don't read and dump pages that are marked as being logically
> >> offline.
> >>
> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> >
> > Thanks for the v2 update.
> > I'm going to merge this patch after the kernel patches are merged
> > and it tests fine with the kernel.
> >
> > Kazu
>
> Hi Kazu,
>
> the patches are now upstream. Thanks!

Tested OK at my end, too. Applied to the devel branch.

Offline pages : 0x0000000000002400

Thank you!
Kazu

>
> --
>
> Thanks,
>
> David / dhildenb