Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

From: Dan Murphy
Date: Mon Mar 11 2019 - 13:47:54 EST


Thanks Joe

On 3/11/19 12:30 PM, Joe Perches wrote:
> On Mon, 2019-03-11 at 12:24 -0500, Dan Murphy wrote:
>> checkpatch takes issue with // in headers.
>> Unless they have removed that requirement.
>
> Awhile ago...
>

I guess I was referring to this SPDX warning

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1: FILE: drivers/net/can/m_can/m_can.h:1:
+//SPDX-License-Identifier: GPL-2.0

> commit dadf680de3c2eb4cba9840619991eda0cfe98778
> Author: Joe Perches <joe@xxxxxxxxxxx>
> Date: Tue Aug 2 14:04:33 2016 -0700
>
> checkpatch: allow c99 style // comments
>
> Sanitise the lines that contain c99 comments so that the error doesn't
> get emitted.
>
> Link: http://lkml.kernel.org/r/d4d22c34ad7bcc1bceb52f0742f76b7a6d585235.1468368420.git.joe@xxxxxxxxxxx
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>


--
------------------
Dan Murphy