Re: [PATCH v2] Bluetooth: hci_qca: Add helper function to get the chip family

From: Matthias Kaehlcke
Date: Mon Mar 11 2019 - 15:05:37 EST


On Mon, Mar 11, 2019 at 11:38:31AM -0700, Matthias Kaehlcke wrote:
> Many functions obtain a 'struct qca_serdev' only to read the btsoc_type
> field. Add a helper function that encapsulates this.
>
> This also fixes crashes observed on platforms with ROME controllers
> that are instantiated through ldisc and not as serdev clients. The
> crashes are caused by NULL pointer dereferentiations, which stem from
> the driver's assumption that a QCA HCI device is always associated with
> a serdev device.
>
> Fixes: fa9ad876b8e0 ("Bluetooth: hci_qca: Add support for Qualcomm
> Bluetooth chip wcn3990")

TBH I'm not sure how useful the 'Fixes' tag is in this case. There are
a bunch of other fixes without the tag, intermingled with a few
improvements and new features.