Re: [PATCH 6/8] move dropping ->ki_eventfd into iocb_destroy()

From: Christoph Hellwig
Date: Mon Mar 11 2019 - 15:46:30 EST


On Sun, Mar 10, 2019 at 07:08:20AM +0000, Al Viro wrote:
> From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Looks sensible, but a changelog would be nice.

> if (iocb->aio_flags & IOCB_FLAG_RESFD) {
> + struct eventfd_ctx *eventfd;
> /*
> * If the IOCB_FLAG_RESFD flag of aio_flags is set, get an
> * instance of the file* now. The file descriptor must be
> * an eventfd() fd, and will be signaled for each completed
> * event using the eventfd_signal() function.
> */
> + eventfd = eventfd_ctx_fdget((int) iocb->aio_resfd);

I don't think there is any point in the cast in either the old or new
code.