RE: [PATCH v3 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

[Vishal Sagar]

Hi Luca,

> -----Original Message-----
> From: Luca Ceresoli [mailto:luca@xxxxxxxxxxxxxxxx]
> Sent: Monday, March 11, 2019 5:38 PM
> To: Vishal Sagar <vsagar@xxxxxxxxxx>; Vishal Sagar <vishal.sagar@xxxxxxxxxx>;
> Hyun Kwon <hyunk@xxxxxxxxxx>; laurent.pinchart@xxxxxxxxxxxxxxxx;
> mchehab@xxxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; Michal
> Simek <michals@xxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx;
> hans.verkuil@xxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Dinesh Kumar <dineshk@xxxxxxxxxx>; Sandip Kothari
> <sandipk@xxxxxxxxxx>
> Subject: Re: [PATCH v3 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI
> CSI-2 Rx Subsystem
> 
> Hi Vishal,
> 
> On 08/03/19 20:04, Vishal Sagar wrote:
> >>> +Optional properties:
> >>> +--------------------
> >>> +- xlnx,vfb: This is present when Video Format Bridge is enabled.
> >>> +  Without this property the driver won't be loaded as IP won't be able to
> >> generate
> >>> +  media bus format compliant stream output.
> >>> +- xlnx,en-csi-v2-0: Present if CSI v2 is enabled in IP configuration.
> >>> +- xlnx,en-vcx: When present, there are maximum 16 virtual channels, else
> >>> +  only 4. This is present only if xlnx,en-csi-v2-0 is present.
> >>> +- xlnx,en-active-lanes: Enable Active lanes configuration in Protocol
> >>> +  Configuration Register.
> >>
> >> This doesn't seem very clear to me. According to my understanding of the
> >> IP and driver, I'd rather rephrase as:
> >>
> >> - xlnx,en-active-lanes: present if the number of active lanes can be
> >>   reconfigured at runtime in the Protocol Configuration Register.
> >>   If present, the V4L2_CID_XILINX_MIPICSISS_ACT_LANES is added.
> >>   Otherwise all lanes are always active.
> >>
> >
> > Your description is better. I will update with this in next version.
> 
> Ok, thanks. But I just noticed an error in my own words...
> "V4L2_CID_XILINX_MIPICSISS_ACT_LANES is added" ->
> "V4L2_CID_XILINX_MIPICSISS_ACT_LANES control is added".
> 
> --
> Luca

Ok I will do this in next round of patch.

Regards
Vishal Sagar