Re: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro
From: Andy Shevchenko
Date: Tue Mar 12 2019 - 05:09:21 EST
On Tue, Mar 12, 2019 at 10:58 AM Masahiro Yamada
> On Tue, Mar 12, 2019 at 4:19 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, Mar 12, 2019 at 6:40 AM Masahiro Yamada
> > <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > > On Sun, Mar 3, 2019 at 4:51 PM William Breathitt Gray
> > > <vilhelm.gray@xxxxxxxxx> wrote:
> > > >
> > > > Replace verbose implementation in set_multiple callback with
> > > > for_each_set_clump8 macro to simplify code and improve clarity. An
> > > > improvement in this case is that banks that are not masked will now be
> > > > skipped.
> > > Please do not do this.
> > >
> > > Nothing in this driver says the GPIO width is 8-bit.
> > Huh?
> > https://elixir.bootlin.com/linux/latest/source/include/dt-bindings/gpio/uniphier-gpio.h#L9
> > Isn't a hardcoding?
> I needed to factor out some magic numbers
> shared between DT and drivers.
Effectively means you introduced an ABI, which we are not supposed to
change, where the number is carved in stone for all hardware covered
by this driver + DT pair.
If you would ever need another one it would require extending existing
bindings without dropping them away.
> Then, dt-bindings is out of realm of operating system.
> If I am doing wrong, I take back my comments, though.
With Best Regards,