Re: [RFC PATCH V2 0/5] vhost: accelerate metadata access through vmap()

From: James Bottomley
Date: Tue Mar 12 2019 - 11:46:55 EST


On Tue, 2019-03-12 at 07:54 -0400, Michael S. Tsirkin wrote:
> On Tue, Mar 12, 2019 at 03:17:00PM +0800, Jason Wang wrote:
> >
> > On 2019/3/12 äå11:52, Michael S. Tsirkin wrote:
> > > On Tue, Mar 12, 2019 at 10:59:09AM +0800, Jason Wang wrote:
[...]
> > At least for -stable, we need the flush?
> >
> >
> > > Three atomic ops per bit is way to expensive.
> >
> >
> > Yes.
> >
> > Thanks
>
> See James's reply - I stand corrected we do kunmap so no need to
> flush.

Well, I said that's what we do on Parisc. The cachetlb document
definitely says if you alter the data between kmap and kunmap you are
responsible for the flush. It's just that flush_dcache_page() is a no-
op on x86 so they never remember to add it and since it will crash
parisc if you get it wrong we finally gave up trying to make them.

But that's the point: it is a no-op on your favourite architecture so
it costs you nothing to add it.

James