Re: [RFC PATCH v3 3/5] tracing: Use tracing error_log with hist triggers
From: Tom Zanussi
Date: Tue Mar 12 2019 - 12:50:59 EST
Hi Masami,
On Wed, 2019-03-13 at 00:46 +0900, Masami Hiramatsu wrote:
> On Mon, 4 Mar 2019 17:36:46 -0600
> Tom Zanussi <zanussi@xxxxxxxxxx> wrote:
>
> > From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> >
> > Replace hist_err() and hist_err_event() with tracing_log_err() from
> > the new tracing error_log mechanism.
> >
> > Also add a couple related helper functions and remove most of the
> > old
> > hist_err()-related code.
> >
> > With this change, users no longer read the hist files for hist
> > trigger
> > error information, but instead look at tracing/error_log for the
> > same
> > information.
>
> Could you also add a patch which update its testcase?
>
> test.d/trigger/inter-event/trigger-extended-error-support.tc
>
> will fail after this patch.
>
Yeah, good point, will do (and documentation too).
Thanks,
Tom