Re: [PATCH] arm64: dts: fsl: imx8mq: enable the thermal management unit (TMU)

From: Angus Ainslie
Date: Tue Mar 12 2019 - 16:19:03 EST


Hi Andrey,

On 2019-03-11 19:35, Andrey Smirnov wrote:
On Mon, Mar 11, 2019 at 2:35 PM Angus Ainslie (Purism) <angus@xxxxxxxx> wrote:

These are the TMU nodes from the NXP vendor kernel


Hey Angus,

TMU block supports multiple thermal zones and vendor kernel doesn't
really account for that (see below). Latest version of the driver in
thermal tree now actually supports that feature (mulit-sensor), so I
think the code in DT should reflect that as well. I recently submitted
a series adding HWMON integration for TMU
(https://lore.kernel.org/lkml/20190222200508.26325-1-andrew.smirnov@xxxxxxxxx/T/#u)

I tried applying those to linux-next. They don't apply very cleanly there so I gave up.

and this is my take on this patch:

https://github.com/ndreys/linux/commit/09931e3d60af0a74377307b433db97da1be31570

All of the code there is up for grabs, if you feel like using it.


I followed that and I have a version that works with linux-next that does not include the GPU
and VPU parts.

I also tested a version with the GPU and VPU parts and it "works" but creates 2 useless
paths in /sys/class/thermal .

Should I wait for your changes to get into linux-next or resubmit a version that works with the current one ?

Thanks
Angus