Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM
From: Takashi Iwai
Date: Wed Mar 13 2019 - 06:29:05 EST
On Mon, 04 Mar 2019 21:33:25 +0100,
Arnd Bergmann wrote:
>
> The #ifdef protection around the PM functions is wrong, leading to
> a failed reference in some configurations:
>
> sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
> sound/pci/hda/hda_tegra.c:273:2: error: implicit declaration of function 'hda_tegra_disable_clocks'; did you mean 'hda_tegra_enable_clocks'? [-Werror=implicit-function-declaration]
>
> Better remove the #ifdefs entirely and rely on the compiler silently
> dropping unused functions marked __maybe_unused.
>
> Fixes: 707e0759f2f4 ("ALSA: hda/tegra: implement runtime suspend/resume")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Applied now. Thanks.
Takashi