Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support

From: Sameer Pujar
Date: Wed Mar 13 2019 - 09:52:22 EST



On 3/13/2019 4:52 PM, Marc Zyngier wrote:
First things first:

- Where is the cover letter?
- This series should be flagged as v2, as it not the same as the one you
sent last week.
I had the dilemma whether to name this series as v2 or not, thought the commits
in the series are different and v2 may not be necessary.
Also felt commit messages are descriptive enough and all belong to irq-gic-pm,
hence did not send cover letter.
If you suggest so, I will send a cover letter next patch version(v2)

On 13/03/2019 11:02, Sameer Pujar wrote:
This is a preparatory patch for using irq-gic-pm driver as module and thus
implement remove() call for the driver. Details of remove() are as below,

* pm_runtime_force_suspend() is added to balance runtime PM, otherwise
following is seen: "agic-controller: Unbalanced pm_runtime_enable!"
* Function gic_teardown() is exported from gic driver and called in remove
to perform io unmap.
* pm_clk_destroy() to free clock resources
* irq is unmapped and freed with irq_dispose_mapping()

Let's be clear, I have no desire to export any GIC symbol at all. Why
should we do this? This "driver" is the tiniest thing, and making it
modular doesn't get us anything.

So what's the rational for doing so?
Reason for this was, the driver gets used for AGIC block and audio is not
boot critical and hence module option was preferred.

Thanks,
Sameer.


Thanks,

M.