Re: [PATCH v7 02/15] sched/core: uclamp: Enforce last task UCLAMP_MAX

[Peter Zijlstra]

On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote:
> +uclamp_idle_value(struct rq *rq, unsigned int clamp_id, unsigned int clamp_value)
> +{
> +	/*
> +	 * Avoid blocked utilization pushing up the frequency when we go
> +	 * idle (which drops the max-clamp) by retaining the last known
> +	 * max-clamp.
> +	 */
> +	if (clamp_id == UCLAMP_MAX) {
> +		rq->uclamp_flags |= UCLAMP_FLAG_IDLE;
> +		return clamp_value;
> +	}
> +
> +	return uclamp_none(UCLAMP_MIN);

That's a very complicated way or writing: return 0, right?

> +}