Re: [PATCH v7 02/12] perf record: implement -f,--mmap-flush=<threshold> option

[Jiri Olsa]

On Tue, Mar 12, 2019 at 08:12:23AM +0300, Alexey Budankov wrote:

SNIP

>  	record__aio_mmap_read_sync(rec);
>  
>  	if (forks) {
> @@ -1815,6 +1863,7 @@ static struct record record = {
>  			.uses_mmap   = true,
>  			.default_per_cpu = true,
>  		},
> +		.mmap_flush          = MMAP_FLUSH_DEFAULT,
>  	},
>  	.tool = {
>  		.sample		= process_sample_event,
> @@ -1881,6 +1930,9 @@ static struct option __record_options[] = {
>  	OPT_CALLBACK('m', "mmap-pages", &record.opts, "pages[,pages]",
>  		     "number of mmap data pages and AUX area tracing mmap pages",
>  		     record__parse_mmap_pages),
> +	OPT_CALLBACK('f', "mmap-flush", &record.opts, "bytes",
> +		     "Minimal number of bytes that is extracted from mmap data pages (default: 1)",
> +		     record__mmap_flush_parse),

let's not consume the 'f' for this option, just --map-flush

jirka