Re: [RFC PATCH 4/7] tracing/probe: Check event/group naming rule at parsing

[Steven Rostedt]

On Thu, 14 Mar 2019 00:04:02 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> > >  		strlcpy(buf, event, slash - event + 1);
> > > +		if (!is_good_name(buf)) {
> > > +			pr_info("Group name must follow the rule of C identifier\n");  
> > 
> > What do you mean by "C identifier"?  
> 
> I meant "the naming rules of C language identifiers". It means
> that the name has to start with alphabet or "_" and only contain
> alphanumeric characters and "_". Does it clear?
> I couldn't think of a good word. maybe "naming convention"
> does not fit...

Ah, OK that now makes sense.

> 
> Would you have any idea?

I think I was more confused by the way it was stated. What about saying:

	"Group names must follow the same rules as C identifiers"

Saying "the rule of C identifiers" made me think more of "the rule of
law", and thought that this had something to do with rules of C
zealots, and those that identify with "C" ;-)

-- Steve