Re: [PATCH v2] lib/siphash.c: annotate implicit fall throughs

From: Mathieu Malaterre
Date: Wed Mar 13 2019 - 16:52:56 EST


On Wed, Mar 13, 2019 at 9:34 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> Conceptually this seems pretty reasonable. Though, style-wise, perhaps
> you might want to put those breaks on the next line too, i.e. s/;
> break;/;\n\t\tbreak;/?

Good point. This needs some more love since checkpatch complains now with:

ERROR: trailing statements should be on next line
#42: FILE: lib/siphash.c:77:
+ case 4: b |= le32_to_cpup(data);

Let me merge all that and send a v2.

Thanks