Re: Re: [External] Re: vmscan: Reclaim unevictable pages

[Kirill Tkhai]

On 14.03.2019 11:52, Pankaj Suryawanshi wrote:
> 
> I am using kernel version 4.14.65 (on Android pie [ARM]).
> 
> No additional patches applied on top of vanilla.(Core MM).
> 
> If I change in the vmscan.c as below patch, it will work. 

Sorry, but 4.14.65 does not have braces around trylock_page(),
like in your patch below.

See https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/mm/vmscan.c?h=v4.14.65

[...]

>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index be56e2e..2e51edc 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -990,15 +990,17 @@ static unsigned long shrink_page_list(struct list_head *page_list,
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ page = lru_to_page(page_list);
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ list_del(&page->lru);
>>
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ if (!trylock_page(page)) {
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ goto keep;
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ }