Re: [PATCH] tcp: don't use __constant_cpu_to_be32

From: Eric Dumazet
Date: Thu Mar 14 2019 - 08:42:20 EST

On Wed, Mar 13, 2019 at 11:15 PM Sergey Senozhatsky
<> wrote:
> A trivial patch.

Not so trivial...

> cpu_to_be32() is capable enough to detect __builtin_constant_p()
> and to use an appropriate compile time ___constant_swahb32()
> function.
> So we can use cpu_to_be32() instead of __constant_cpu_to_be32().

I dunno, this is uapi, this might break user space for some funky compiler ?

I do not even know if cpu_to_be32() _is_ uapi.