Re: [Xen-devel] [PATCH v1] xen/balloon: Fix mapping PG_offline pages to user space

[David Hildenbrand]

On 14.03.19 16:49, Jan Beulich wrote:
>>>> On 14.03.19 at 16:40, <david@xxxxxxxxxx> wrote:
>> --- a/drivers/xen/balloon.c
>> +++ b/drivers/xen/balloon.c
>> @@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
>>  	while (pgno < nr_pages) {
>>  		page = balloon_retrieve(true);
>>  		if (page) {
>> +			__ClearPageOffline(page);
>>  			pages[pgno++] = page;
> 
> While this one's fine, ...
> 
>> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>>  
>>  	for (i = 0; i < nr_pages; i++) {
>>  		if (pages[i])
>> +			__SetPageOffline(pages[i]);
>>  			balloon_append(pages[i]);
>>  	}
> 
> ... I think you want to add a pair of braces here.
> 
> Jan
> 
> 

Indeed, dropped by accident. Will resend in a minute. Thanks!

-- 

Thanks,

David / dhildenb