Re: [PATCH tip/core/rcu 06/19] rcu: Add warning to detect half-interrupts

From: Joel Fernandes
Date: Thu Mar 14 2019 - 17:29:10 EST


On Thu, Mar 14, 2019 at 09:37:46AM -0400, Steven Rostedt wrote:
> On Thu, 14 Mar 2019 09:36:57 -0400
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > On Thu, 14 Mar 2019 08:31:59 -0400
> > Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:
> >
> > > Oh thanks for pointing that out. Yes it does work for me. I agree with the
> > > lockdep API addition and others could benefit from it too. I will incorporate
> > > the lockdep API addition into the RCU patch, but let me know if I should
> > > rather split it.
> >
> > I'd recommend splitting it (adding the lockdep_assert in a patch by
> > itself), but make sure that patch Cc's the lockdep maintainers and
> > explains the reason for adding it. Might as well Cc the lockdep
> > maintainers on the entire series too.
> >
>
> Feel free to add "Suggested-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>"
> on that patch too.

Will definitely split it and add your tag. Thanks!

- Joel