Re: [PATCH] mm: Fix __dump_page when mapping->host is not set

[Oscar Salvador]

On Fri, Mar 15, 2019 at 01:47:33PM +0100, Michal Hocko wrote:
> diff --git a/mm/debug.c b/mm/debug.c
> index 1611cf00a137..499c26d5ebe5 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -78,6 +78,9 @@ void __dump_page(struct page *page, const char *reason)
>  	else if (PageKsm(page))
>  		pr_warn("ksm ");
>  	else if (mapping) {
> +		if (PageSwapCache(page))
> +			mapping = page_swap_info(page)->swap_file->f_mapping;
> +
>  		pr_warn("%ps ", mapping->a_ops);
>  		if (mapping->host->i_dentry.first) {
>  			struct dentry *dentry;

This looks like a much nicer fix, indeed.
I gave it a spin and it works.

Since the mapping is set during the swapon, I would assume that this should
always work for swap.
Although I am not sure if once you start playing with e.g zswap the picture can
change.

Let us wait for Hugh and Jan.

Thanks Michal

-- 
Oscar Salvador
SUSE L3