Re: [PATCH 00/16] media: vimc: Add support for multiplanar formats

[Helen Koike]

Hi Andre,

Thanks for you patch. I didn't do a full review, but I did some minor
comments, please check.

Thanks
Helen

On 3/15/19 2:29 PM, Andrà Almeida wrote:
> 
> 
> On 3/15/19 1:43 PM, Andrà Almeida wrote:
>> Hello,
>>
>> This series implements support for multiplane pixel formats at vimc.
>> A lot of changes were required since vimc support for singleplane
>> was "hardcoded". The code has been adapted in order to support both
>> formats. When was possible, the functions were written generically,
>> avoiding functions for just one type of pixel format (single/multi)
>> and favoring code reuse.
>>
>> The debayer subdevice is the only one that currently doesn't supports
>> multiplanar formats. Documentation to each device will be made in a
>> future patch.
>>
> 
> Forgot to mention that this patch series depends on this one:
> 
> "[PATCH] media: vimc: propagate pixel format in the stream"
> 
>> Thanks,
>> ÂÂÂÂAndrÃ
>>
>> Andrà Almeida (16):
>> ÂÂ media: Move sp2mp functions to v4l2-common
>> ÂÂ media: vimc: Remove unnecessary stream check
>> ÂÂ media: vimc: Check if the stream is on using ved.stream
>> ÂÂ media: vimc: cap: Change vimc_cap_device.format type
>> ÂÂ media: vimc: Create multiplanar parameter
>> ÂÂ media: vimc: cap: Dynamically define stream pixelformat
>> ÂÂ media: vimc: cap: Add handler for singleplanar fmt ioctls
>> ÂÂ media: vimc: cap: Add handler for multiplanar fmt ioctls
>> ÂÂ media: vimc: cap: Add multiplanar formats
>> ÂÂ media: vimc: cap: Add multiplanar default format
>> ÂÂ media: vimc: cap: Allocate and verify mplanar buffers
>> ÂÂ media: vimc: Add and use new struct vimc_frame
>> ÂÂ media: vimc: sen: Add support for multiplanar formats
>> ÂÂ media: vimc: sca: Add support for multiplanar formats
>> ÂÂ media: vimc: cap: Add support for multiplanar formats
>> ÂÂ media: vimc: cap: Dynamically define device caps
>>
>> Â drivers/media/platform/vimc/vimc-capture.cÂÂÂ | 310 +++++++++++++++---
>> Â drivers/media/platform/vimc/vimc-common.cÂÂÂÂ |Â 37 +++
>> Â drivers/media/platform/vimc/vimc-common.hÂÂÂÂ |Â 50 ++-
>> Â drivers/media/platform/vimc/vimc-core.cÂÂÂÂÂÂ |ÂÂ 8 +
>> Â drivers/media/platform/vimc/vimc-debayer.cÂÂÂ |Â 38 +--
>> Â drivers/media/platform/vimc/vimc-scaler.cÂÂÂÂ | 125 ++++---
>> Â drivers/media/platform/vimc/vimc-sensor.cÂÂÂÂ |Â 62 ++--
>> Â drivers/media/platform/vimc/vimc-streamer.cÂÂ |ÂÂ 2 +-
>>  drivers/media/platform/vivid/vivid-vid-cap.c | 6 +-
>> Â .../media/platform/vivid/vivid-vid-common.cÂÂ |Â 59 ----
>> Â .../media/platform/vivid/vivid-vid-common.hÂÂ |ÂÂ 9 -
>>  drivers/media/platform/vivid/vivid-vid-out.c | 6 +-
>> Â drivers/media/v4l2-core/v4l2-common.cÂÂÂÂÂÂÂÂ |Â 62 ++++
>> Â include/media/v4l2-common.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 31 ++
>> Â 14 files changed, 580 insertions(+), 225 deletions(-)
>>