Re: [GIT PULL] AFS fixes and other bits

From: David Howells
Date: Sat Mar 16 2019 - 03:55:59 EST


Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> The thing hasn't even seen a compiler, and when you *do* show the code
> to a compiler, said compiler correctly warns about

No, it doesn't - at least not gcc-8.3.1 on Fedora 29. What compiler are you
using?

> afs_do_silly_unlink() potentially returning an uninitialized variable.

Not only has it seen a compiler, it's also been tested numerous times, with
firefox, sqlite and some commands that tests file locking manually.

But please hold off for now. I've just tried the system flock program - and
that causes a lock leakage message for some reason that needs investigating.

David