RE: [PATCH V4 2/5] pwm: Add i.MX TPM PWM driver support
From: Anson Huang
Date: Mon Mar 18 2019 - 10:42:08 EST
Hi, Uwe
Yes, I will post a V6, but before sending V6, can you help confirm if you agree my 2 answers for your last comments, such as the counter disable for changing prescale and the mutex lock in .apply function?
Best Regards!
Anson Huang
> -----Original Message-----
> From: Uwe Kleine-KÃnig [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> Sent: 2019å3æ18æ 22:11
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: thierry.reding@xxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; otavio@xxxxxxxxxxxxxxxx;
> stefan@xxxxxxxx; Leonard Crestez <leonard.crestez@xxxxxxx>;
> schnitzeltony@xxxxxxxxx; jan.tuerk@xxxxxxxxxxx; Robin Gong
> <yibin.gong@xxxxxxx>; linux-pwm@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH V4 2/5] pwm: Add i.MX TPM PWM driver support
>
> Hello,
>
> as you got some feedback for v5 already I assume you will post a v6.
> I'll skip reviewing v5 then.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-KÃnig |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> engutronix.de%2F&data=02%7C01%7Canson.huang%40nxp.com%7C79
> 7514afffcb4f799bf408d6abab9188%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636885150706417201&sdata=kVut1X8JtjGdGOM2czyRRc
> 5di77I2Hu8dQttf8DJn1A%3D&reserved=0 |