Re: [PATCH 2/2] tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

[Razvan.Stefanescu]

On 18/03/2019 16:30, Richard Genoud wrote:
>> +		/* Start RX if flag was set and FIFO is empty */
>> +		if (atmel_port->hd_start_rx) {
>> +			if (atmel_uart_readl(port, ATMEL_US_CSR)
>> +					& ATMEL_US_TXEMPTY) {
>> +				atmel_port->hd_start_rx = false;
>> +				atmel_start_rx(port);
>> +			} else {
>> +				dev_warn(port->dev, "Should start RX, but TX fifo is not empty\n");
> What will happen in this case ?
> 

RX will not be started. I haven't been able to trigger this error case. 
Would it be better to start RX anyway and just display the error message 
if TX fifo is not empty? But this way it will be like before this fix, 
in case of an error.

Thank you,
Razvan