RE: [PATCH V6 4/5] ARM: dts: imx7ulp: Add pwm0 support
From: Anson Huang
Date: Tue Mar 19 2019 - 03:01:18 EST
Best Regards!
Anson Huang
> -----Original Message-----
> From: Uwe Kleine-KÃnig [mailto:u.kleine-koenig@xxxxxxxxxxxxxx]
> Sent: 2019å3æ19æ 14:55
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: thierry.reding@xxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; stefan@xxxxxxxx;
> otavio@xxxxxxxxxxxxxxxx; Leonard Crestez <leonard.crestez@xxxxxxx>;
> schnitzeltony@xxxxxxxxx; jan.tuerk@xxxxxxxxxxx; Robin Gong
> <yibin.gong@xxxxxxx>; linux-pwm@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH V6 4/5] ARM: dts: imx7ulp: Add pwm0 support
>
> On Tue, Mar 19, 2019 at 06:50:26AM +0000, Anson Huang wrote:
> > Add i.MX7ULP EVK board PWM0 support.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> > Changes since V5:
> > - change #pwm-cells to 3.
> > ---
> > arch/arm/boot/dts/imx7ulp-evk.dts | 12 ++++++++++++
> > arch/arm/boot/dts/imx7ulp.dtsi | 10 ++++++++++
>
> IMHO the change to the evk.dts belongs into the last patch.
Ah, yes, the PWM pin settings in board dts should belongs into the backlight patch,
I will resend V6, thanks.
Anson.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-KÃnig |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> engutronix.de%2F&data=02%7C01%7Canson.huang%40nxp.com%7Ce3
> 645a6d4d6643a1f80f08d6ac37c725%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636885752897208572&sdata=N67sms9lX6asXpYaq%2Ftf
> TNpNz%2BeDIKNx89%2F57CYQAwA%3D&reserved=0 |