Re: [PATCH v2] usb: introduce usb_ep_type_string() function

From: Felipe Balbi
Date: Wed Mar 20 2019 - 02:55:25 EST


Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> writes:

> Hi Greg,
>
> On Tue, 2019-03-19 at 10:23 +0100, Greg Kroah-Hartman wrote:
>> On Tue, Mar 19, 2019 at 03:54:19PM +0800, Chunfeng Yun wrote:
>> >
>> > Hi Felipe & Mathias,
>> >
>> > Could you please comment this patch, if there is some-effect on dwc3 and
>> > xhci, I'll remove its change.
> typo: some-effect/side-effect

well, we don't really know if there are tools parsing the output. The
side-effect _does_ exist (i.e. you change the string :-), what we don't
know is if this will cause problems to possibly existing tools.

Personally, I don't mind the patch, but if it breaks existing parsers,
that would be a little annoying.

--
balbi

Attachment: signature.asc
Description: PGP signature