Re: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup

From: Mika Westerberg
Date: Wed Mar 20 2019 - 06:51:12 EST


On Mon, Mar 18, 2019 at 05:55:08PM -0500, Aditya Pakki wrote:
> @@ -1417,8 +1420,7 @@ bool tb_xdomain_handle_request(struct tb *tb, enum tb_cfg_pkg_type type,
> */
> if (uuid_equal(&hdr->uuid, &tb_xdp_uuid)) {
> if (type == TB_CFG_PKG_XDOMAIN_REQ) {
> - tb_xdp_schedule_request(tb, hdr, size);
> - return true;
> + return tb_xdp_schedule_request(tb, hdr, size);

Please remove parens as well that there is only a single statement
following the if-block.

Otherwise looks fine.