Re: [PATCH 7/9] nvme/core: add mdev interfaces

From: Stefan Hajnoczi
Date: Wed Mar 20 2019 - 07:46:29 EST


On Tue, Mar 19, 2019 at 04:41:14PM +0200, Maxim Levitsky wrote:
> +int nvme_core_register_mdev_driver(struct nvme_mdev_driver *driver_ops)
> +{
> + struct nvme_ctrl *ctrl;
> +
> + if (mdev_driver_interface)
> + return -EEXIST;
> +
> + mdev_driver_interface = driver_ops;

Can mdev_driver_interface be accessed from two CPUs at the same time?
mdev_driver_interface isn't protected by the mutex. The state_changed
functions below also don't protect mdev_driver_interface.

Attachment: signature.asc
Description: PGP signature