Re: [PATCH] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86

[Robert Richter]

On 20.03.19 13:16:13, Robert Richter wrote:

> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> index 4a0dfe4ab829..c250b767030e 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -162,14 +162,10 @@ void efi_virtmap_unload(void)
>  static int __init arm_dmi_init(void)
>  {
>  	/*
> -	 * On arm64/ARM, DMI depends on UEFI, and dmi_scan_machine() needs to
> +	 * On arm64/ARM, DMI depends on UEFI, and dmi_setup() needs to
>  	 * be called early because dmi_id_init(), which is an arch_initcall
>  	 * itself, depends on dmi_scan_machine() having been called already.
>  	 */
> -	dmi_scan_machine();
> -	dmi_memdev_walk();
> -	if (dmi_available)
> -		dmi_set_dump_stack_arch_desc();

This went wrong in the last stage of a comment rework. A dmi_setup()
should be here. Will resubmit. Sorry.

-Robert

>  	return 0;
>  }