Re: [PATCH] gpio: amd-fch: Fix bogus SPDX identifier
From: Enrico Weigelt, metux IT consult
Date: Wed Mar 20 2019 - 12:05:02 EST
On 19.03.19 15:28, Thomas Gleixner wrote:
> spdxcheck.py complains:
>
> include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
>
> which is correct because GPL+ is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
>
> WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
> #271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
> +/* SPDX-License-Identifier: GPL+ */
>
> Fix it under the assumption that the author meant GPL-2.0+, which makes
> sense as the corresponding C file is using that identifier.
Your assumption is correct.
Acked-By: Enrico Weigelt <info@xxxxxxxxx>
I just wonder, why checkpatch.pl didn't bleat me.
Thanks for the fix.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287