RE: [PATCH v2 3/3] MIPS: eBPF: Initial eBPF support for MIPS32 architecture.

[Hassan Naveed]

Hi Daniel,

> >
> >On 03/12/2019 11:48 PM, Hassan Naveed wrote:
> >> Currently MIPS32 supports a JIT for classic BPF only, not extended BPF.
> >> This patch adds JIT support for extended BPF on MIPS32, so code is
> >> actually JIT'ed instead of being only interpreted. Instructions with
> >> 64-bit operands are not supported at this point.
> >> We can delete classic BPF because the kernel will translate classic
> >> BPF programs into extended BPF and JIT them, eliminating the need for
> >> classic BPF.
> >>
> >> Signed-off-by: Hassan Naveed <hnaveed@xxxxxxxxxxxx>
> >
> >Nice! Did you check BPF test suite (lib/test_bpf.ko) that both before/after the
> >same number of cBPF programs could be JITed?

Yes, we did check that and the number of tests JITed is same. Hence we thought it's better to get rid of cBPF and simplify things.

> >
> >Please also follow-up to update Documentation/sysctl/net.txt, bpf_jit_enable
> >section, and adding yourself as co-maintainer for 'BPF JIT for MIPS' wouldn't
> >hurt either if Paul would be good with that, too.
> >

I'll update the bpf_jit_enable section in the next patch. I believe this one is already applied.

> >Any plans on completing eBPF support for mips32?

It definitely is on my to-do list, though I'm not quite sure when I'd be able to get to it.
> >
> >Thanks,
> >Daniel