Re: [PATCH] xen, fbfront: mark expected switch fall-through

[Gustavo A. R. Silva]

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
> +Xen-devel list
> 
> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/video/fbdev/xen-fbfront.c: In function âxenfb_backend_changedâ:
>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> ÂÂÂ if (dev->state == XenbusStateClosed)
>> ÂÂÂÂÂÂ ^
>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>> ÂÂ case XenbusStateClosing:
>> ÂÂ ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> ---
>> Â drivers/video/fbdev/xen-fbfront.c | 2 +-
>> Â 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>> --- a/drivers/video/fbdev/xen-fbfront.c
>> +++ b/drivers/video/fbdev/xen-fbfront.c
>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>> ÂÂÂÂÂ case XenbusStateClosed:
>> ÂÂÂÂÂÂÂÂÂ if (dev->state == XenbusStateClosed)
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ break;
>> -ÂÂÂÂÂÂÂ /* Missed the backend's CLOSING state -- fallthrough */
>> +ÂÂÂÂÂÂÂ /* fall through - Missed the backend's CLOSING state. */
>> ÂÂÂÂÂ case XenbusStateClosing:
>> ÂÂÂÂÂÂÂÂÂ xenbus_frontend_closed(dev);
>> ÂÂÂÂÂÂÂÂÂ break;
>