Re: [PATCH v6 6/7] refactor header includes to allow kthread.h inclusion in psi_types.h

From: Johannes Weiner
Date: Wed Mar 20 2019 - 17:04:09 EST


On Tue, Mar 19, 2019 at 04:56:18PM -0700, Suren Baghdasaryan wrote:
> kthread.h can't be included in psi_types.h because it creates a circular
> inclusion with kthread.h eventually including psi_types.h and complaining
> on kthread structures not being defined because they are defined further
> in the kthread.h. Resolve this by removing psi_types.h inclusion from the
> headers included from kthread.h.
>
> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>

> @@ -26,7 +26,6 @@
> #include <linux/latencytop.h>
> #include <linux/sched/prio.h>
> #include <linux/signal_types.h>
> -#include <linux/psi_types.h>
> #include <linux/mm_types_task.h>
> #include <linux/task_io_accounting.h>
> #include <linux/rseq.h>

Ah yes, earlier versions of the psi patches had a psi_task struct or
something embedded in task_struct. It's all just simple C types now.

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>